skywalker3200/Stargate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop bundling DB drivers into the proxy jars

Browse Source 
stargate-common declared HikariCP/SQLite/MySQL as implementation deps,
which leaked transitively into stargate-velocity and stargate-bungee
even though neither touches storage. That bloated each proxy jar from
~15KB to ~18MB for nothing. Switched to compileOnly in stargate-common;
stargate-paper already redeclares them as implementation so its shaded
jar is unaffected.
This commit is contained in:
Michael Burgess
2026-08-09 10:23:04 -04:00
parent c99f4c9f85
commit 89d4fa0b63
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stargate-common/build.gradle.kts
+5 -3
View File
@@ -1,8 +1,10 @@
dependencies { dependencies {
// compileOnly, not implementation: these are only needed to compile SqlGateStorage here.
// Actually bundling them for runtime is the paper module's job (it redeclares them as
// implementation) - stargate-velocity/stargate-bungee depend on this module too but never
// touch storage, so leaking these as transitive implementation deps would bloat their
// shaded jars with an unused JDBC/HikariCP stack for no reason.
compileOnly("com.zaxxer:HikariCP:5.1.0") compileOnly("com.zaxxer:HikariCP:5.1.0")
implementation("com.zaxxer:HikariCP:5.1.0")
compileOnly("org.xerial:sqlite-jdbc:3.46.1.3") compileOnly("org.xerial:sqlite-jdbc:3.46.1.3")
implementation("org.xerial:sqlite-jdbc:3.46.1.3")
compileOnly("com.mysql:mysql-connector-j:8.4.0") compileOnly("com.mysql:mysql-connector-j:8.4.0")
implementation("com.mysql:mysql-connector-j:8.4.0")
} }