From 6579c4bf0e56901f1dfd320bb0636d10ead7510f Mon Sep 17 00:00:00 2001 From: Andreas Troelsen Date: Mon, 18 Sep 2023 23:28:45 +0200 Subject: [PATCH] Call `update()` when reparing signs. It boggles the mind that this tiny little class has worked as intended since 2011 (!!), and all of a sudden, signs no longer retain their text in the repair procedure... By calling the somewhat arbitrary `update()` method on the sign after setting the contents, the sign appears to correctly update again. Fixes #772 --- changelog.md | 1 + .../java/com/garbagemule/MobArena/repairable/RepairableSign.java | 1 + 2 files changed, 2 insertions(+) diff --git a/changelog.md b/changelog.md index 9fea934..db192da 100644 --- a/changelog.md +++ b/changelog.md @@ -15,6 +15,7 @@ These changes will (most likely) be included in the next version. - Explosion damage caused by Exploding Sheep now correctly counts as monster damage. This means that the explosions only affect other mobs if the per-arena setting `monster-infight` is set to `true`. - Explosion damage caused by the boss ability `obsidian-bomb` now correctly counts as monster damage. This means that the explosions only affect other mobs if the per-arena setting `monster-infight` is set to `true`. - An old discrepancy with auto start timers in the auto-ready logic has been removed. This fixes an issue in MobArenaStats where the extension would throw errors in arenas with `auto-ready: true` and a non-zero auto start timer. Note that the combination of `auto-ready: true` and a `default-class` now _requires_ the use of a `start-delay-timer` to prevent the arena from starting immediately when the first player joins. +- Signs now correctly restore themselves again in arenas with `soft-restore: true`. ## [0.107] - 2022-07-30 ### Added diff --git a/src/main/java/com/garbagemule/MobArena/repairable/RepairableSign.java b/src/main/java/com/garbagemule/MobArena/repairable/RepairableSign.java index 44c7af9..d396d2d 100644 --- a/src/main/java/com/garbagemule/MobArena/repairable/RepairableSign.java +++ b/src/main/java/com/garbagemule/MobArena/repairable/RepairableSign.java @@ -27,6 +27,7 @@ public class RepairableSign extends RepairableAttachable s.setLine(1, lines[1]); s.setLine(2, lines[2]); s.setLine(3, lines[3]); + s.update(); } }